This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed] : [patch] refactor arm-tdep.c:install_ldr_str_ldrb_strb to handle halfword
- From: Yao Qi <yao at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 17 Sep 2011 22:39:53 +0800
- Subject: [committed] : [patch] refactor arm-tdep.c:install_ldr_str_ldrb_strb to handle halfword
- References: <201107151849.p6FInxRx004350@d06av02.portsmouth.uk.ibm.com>
On 07/16/2011 02:49 AM, Ulrich Weigand wrote:
> Yao Qi wrote:
>
>> * arm-tdep.c (install_ldr_str_ldrb_strb): Renamed to ...
>> (install_load_store): ... this. New.
>> Change parameter BYTE to SIZE.
>> (arm_copy_ldr_str_ldrb_strb): Update caller.
>> (arm_decode_ld_st_word_ubyte): Update caller.
>
> This is OK. It might be a good idea now to use the new
> install_load_store routine also for arm_copy_extra_ld_st
> (which is where half-/doubleword instructions are decoded
> for ARM) to reduce some duplication. But that could also
> be done as a follow-on patch ...
>
Committed. http://sourceware.org/ml/gdb-cvs/2011-09/msg00111.html
--
Yao (éå)