Re: [PATCH] [PR 9514] Fixing parse error for "pointer to a function pointer"

[Pedro Alves <pedro at codesourcery dot com>]

On Thursday 29 September 2011 11:44:04, Abhijit Halder wrote:
> On Thu, Sep 29, 2011 at 4:10 PM, Abhijit Halder
> <abhijit.k.halder@gmail.com> wrote:
> > Hi all,
> >
> > The current patch is to fix the issue defined in PR 9514. There's no
> > regression. Please review this.
> >
> > Thanks,
> > Abhijit Halder
> >
> 
> Oops! The ChangeLog is incorrect. Correcting the same.

Please always post both ChangeLog and patch together.  It's
practically 0 work to repost the whole thing instead of just a
part, while having all pieces together is easier for review, as
it avoids the reviewer, not being as familiar with the patches
as you, having to hunt for the pieces.  Also, please always try
to give explanations of what was wrong in the current code, and how
you're fixing the problem.  If you found a problem with an earlier
patch attempt, it's quite useful to know why that earlier patch didn't
work.  If a reviewer will need to try out a patch and go through
the same debug/thought process you had to go throught when writting
the patch, then it's more likely a patch will go by unreviewed
for longer.  In a nutshell, your job is to make it easy to get an OK.

-- 
Pedro Alves