This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python] [patch] PR python/12656 (API for special blocks)


Eli Zaretskii <eliz@gnu.org> writes:

>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Mon, 17 Oct 2011 11:31:06 +0100
>> 
>> doco ping
>
> Sorry, missed the original posting.
>
> I have a couple of comments:
>
>> +@defvar Block.is_global ()
>> +@code{True} if the @code{gdb.Block} object is the global block
>> +for the inferior, @code{False} if not.  This attribute is not
>> +writable.
>
> If this is an attribute, why do you use "()" on the @defvar line?

They used to be methods in a previous posting, I just forgot to remove
the "()"'s when I converted them to attributes.  Fixed locally.

> Also, what do you mean by "the global block for the inferior"? why
> "the" global block?  There could be more than one such block, right?

Oops, fixed and for static too.

> And the same goes for the static attribute.

Is this ok, or do you want me to re-post the patch?

Cheers,

Phil


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]