This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Mon, 17 Oct 2011 09:57:24 -0700
- Subject: Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC
- References: <1310418640-32168-1-git-send-email-vapier@gentoo.org>
> 2011-07-11 Mike Frysinger <vapier@gentoo.org>
>
> * aclocal.m4 (SIM_AC_COMMON): Call AC_REQUIRE on AC_PROG_CC.
> Delete direct call to AC_PROG_CC.
Looks, OK, except why did you move the call up?
Looking at the autoconf documentation, AC_CONFIG_HEADER does not need
to be called right after AC_INIT, it is only customary. So if there is
a reason for us to change the location of the use of AC_PROG_CC, we
probably want to fix the comment as well.
> ---
> sim/common/aclocal.m4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sim/common/aclocal.m4 b/sim/common/aclocal.m4
> index 264cced..3ed5efd 100644
> --- a/sim/common/aclocal.m4
> +++ b/sim/common/aclocal.m4
> @@ -24,11 +24,11 @@ sinclude([../../config/zlib.m4])
>
> AC_DEFUN([SIM_AC_COMMON],
> [
> +AC_REQUIRE([AC_PROG_CC])
> # autoconf.info says this should be called right after AC_INIT.
> AC_CONFIG_HEADER(ifelse([$1],,config.h,[$1]):config.in)
> AC_CANONICAL_SYSTEM
> AC_ARG_PROGRAM
> -AC_PROG_CC
> AC_PROG_INSTALL
>
> # Put a plausible default for CC_FOR_BUILD in Makefile.
> --
> 1.7.6
--
Joel