This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: dv-cfi: include stdbool.h
- From: Mike Frysinger <vapier at gentoo dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Mon, 17 Oct 2011 13:06:33 -0400
- Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h
- References: <1310410693-20883-1-git-send-email-vapier@gentoo.org> <20111017165024.GB17942@adacore.com>
On Monday 17 October 2011 12:50:24 Joel Brobecker wrote:
> > The dv-cfi code uses the bool type but doesn't include the stdbool.h
> > header. I didn't notice for Blackfin targets as the core Blackfin
> > header will include stdbool.h, but most targets don't do this.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >
> > 2011-07-11 Mike Frysinger <vapier@gentoo.org>
> >
> > * dv-cfi.c: Include stdbool.h.
>
> I don't think that this is right. stdbool.h is C99, whereas GDB should
> build with a C90 compiler.
hmm, i was not aware of this. i thought it dated back further.
> What we should do is get rid of uses of true and false, and use the
> typical zero/nonzero values instead. I think that the blackfin header
> and code should be cleaned up accordingly as well.
ah, this would make me sad. would a configure check for stdbool.h be
acceptable ?
-mike