This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [testcase patch] 7.2 regression on expand psymtabs
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Oct 2011 16:17:33 +0200
- Subject: Re: [testcase patch] 7.2 regression on expand psymtabs
- References: <20101121213020.GA26240@host0.dyn.jankratochvil.net>
Hi Keith,
original post: http://sourceware.org/ml/gdb-patches/2010-11/msg00300.html
On Sun, 21 Nov 2010 22:30:20 +0100, Jan Kratochvil wrote:
> there is a regression by the patch:
> 42284fdf9d8cdb20c8e833bdbdb2b56977fea525
> http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html
> dwarf2_physname patchset:
> [RFA] dwarf2_physname FINAL
> http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html
[...]
> gdb/testsuite/
> 2010-11-21 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.cp/expand-psymtabs-cxx.exp: New file.
> * gdb.cp/expand-psymtabs-cxx.cc: New file.
I have found this testfile by me went FAIL->PASS by:
Re: [patch 0/3] Re: [RFA] c++/11734 revisited (and c++/12273)
http://sourceware.org/ml/gdb-patches/2011-03/msg00880.html
= two commits:
commit 9e2e8e2f9323fe17ceafb49d8eca9e3117947066
Author: Keith Seitz <keiths@redhat.com>
Date: Wed Mar 16 21:12:11 2011 +0000
* linespec.c (find_methods): Canonicalize NAME before looking
up the symbol.
(name_end): New function.
(keep_name_info): New function.
(decode_line_1): Use keep_name_info.
(decode_compound): Likewise.
* cli/cli-utils.h (remove_trailing_whitespace): New function.
* cli/cli-utils.c (remove_trailing_whitespace): Likewise.
PR c++/12273
* linespec.c (locate_first_half): Keep overload information, too.
(decode_compound): Use a string to represent break characters
to escape the loop.
If P points to a break character, do not increment it.
For C++ and Java, keep overload information and relevant keywords.
If we cannot find a symbol, search the minimal symbols.
PR c++/11734
* linespec.c (decode_compound): Rename SAVED_ARG to
THE_REAL_SAVED_ARG.
Make a copy of THE_REAL_SAVED_ARG in SAVED_ARG and strip
single-quotes.
Pass a valid block to lookup_symbol.
(lookup_prefix_sym): Likewise.
(find_method): Construct search name based on SYM_CLASS instead
of SAVED_ARG.
* psymtab.c (lookup_partial_symbol): Add language parameter.
(lookup_symbol_aux_psymtabs): Likewise.
Don't assume that the psymtab we found was the right one. Search
for the desired symbol in the symtab to be certain.
(psymtab_search_name): New function.
(lookup_partial_symbol): Use psymtab_search_name.
Add language parameter.
(read_symtabs_for_function): Add language parameter and pass to
lookup_partial_symbol.
(find_symbol_file_from_partial): Likewise.
commit bb108bccb87a6e3b166a2ba74cc3aaf192c687ff
Author: Keith Seitz <keiths@redhat.com>
Date: Wed Mar 16 21:08:56 2011 +0000
PR c++/12273
* gdb.cp/cmpd-minsyms.exp: New test.
* gdb.cp/cmpd-minsyms.cc: New file.
PR c++/11734
* gdb.cp/ovsrch.exp: New test.
* gdb.cp/ovsrch.h: New file.
* gdb.cp/ovsrch1.cc: New file.
* gdb.cp/ovsrch2.cc: New file.
* gdb.cp/ovsrch3.cc: New file.
* gdb.cp/ovsrch4.cc: New file.
I think these testcases do not cover the issue tested by this posted testfile.
Therefore going to check it in unless you tell otherwise. A redundant
testfile would not be such a tragedy anyway.
Thanks,
Jan