This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] PR python/13331
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 27 Oct 2011 11:31:14 +0100
- Subject: Re: [python] [patch] PR python/13331
- References: <m3ipne7chg.fsf@redhat.com> <m339eicxe7.fsf@fleche.redhat.com>
- Reply-to: pmuldoon at redhat dot com
Tom Tromey <tromey@redhat.com> writes:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> 2011-10-24 Phil Muldoon <pmuldoon@redhat.com>
> Phil> PR python/13331
> Phil> * python/py-function.c (fnpy_call): Check 'args' is not NULL.
> Phil> (convert_values_to_python): Return on Python tuple allocation
> Phil> failure.
>
> Phil> + if (! result)
> Phil> + return NULL;
>
> I think the function should have a single return convention.
> One easy way to do that would be to remove the 'error' call and have it
> return NULL when value_to_value_object fails.
Committed with requested change (return NULL on value conversion
error).
Cheers,
Phil