This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Status of 'blacklist' patch?

>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:

One more note...

Justin> +int
Justin> +function_pc_is_marked_for_skip (CORE_ADDR pc)
Justin> +{
Justin> +  int searched_for_sal = 0;
Justin> +  struct symtab_and_line sal;
Justin> +  char *filename = NULL;
Justin> +  struct skiplist_entry *e;
Justin> +
Justin> +  sal = find_pc_line (pc, 0);
Justin> +  filename = sal.symtab->filename;

These last two lines should be removed.
They defeat the lazy computation scheme.

Justin> +	      sal = find_pc_line (pc, 0);
Justin> +	      filename = sal.symtab->filename;

I think sal.symtab can be NULL.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]