This is the mail archive of the
mailing list for the GDB project.
Re: [python] [patch] PR python/13345
- From: Meador Inge <meadori at codesourcery dot com>
- To: pmuldoon at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 01 Nov 2011 13:05:39 -0500
- Subject: Re: [python] [patch] PR python/13345
- References: <firstname.lastname@example.org> <4EAFFCEB.email@example.com> <firstname.lastname@example.org>
On 11/01/2011 09:14 AM, Phil Muldoon wrote:
> Meador Inge <email@example.com> writes:
>> On 10/31/2011 10:51 AM, Phil Muldoon wrote:
>>> This patch fixes a case where the tilde (~) command was being passed to
>>> Python via the "source" command. Python does not understand what to do
>>> with a tilde, so we have to expand it first.
>> While I can't give an OK, I did review this and was able to reproduce
>> the stated problem and the patch fixes it. So, LGTM. What about
>> a test case, though? You could construct a relative path to a
>> test directory from '~/'.
> The only addition in the patch was tilde_expand, and an additional error
> check. tilde_expand is a readline function. So we would be testing
> that, more or less. I do normally write regression tests, but I felt
> for this one it was not necessary as the patch is somewhat trivial.
> Plus I am not sure how constructing a path with a ~ in it would work on
> mingw builds? If so, and we really do want one, I can attempt to write
That seems reasonable. I agree the test case can be skipped. Just figured I
would ask ...
CodeSourcery / Mentor Embedded