This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[obv] testsuite false ERROR: gdb.base/commands.exp: cmd1 error
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 3 Nov 2011 18:45:54 +0100
- Subject: [obv] testsuite false ERROR: gdb.base/commands.exp: cmd1 error
Hi,
with gdbserver this patch fixes:
0x000000368f8016e0 in _start () from /lib64/ld-linux-x86-64.so.2^M
(gdb) continue^M
Continuing.^M
hook-stop1^M
^M
Breakpoint 3, main (argc=1, argv=0x7fffffffe0d8, envp=0x7fffffffe0e8) at ./gdb.base/run.c:57^M
57 printf ("%d\n", factorial (1));^M
cmd1^M
Undefined command: "errorcommandxy". Try "help".^M
-(gdb) ERROR: Undefined command "".
-UNRESOLVED: gdb.base/commands.exp: cmd1 error
+(gdb) PASS: gdb.base/commands.exp: cmd1 error
as gdb_run_cmd with use_gdb_stub eats out all [\r\n] after the Continue
message.
Checked in. Tested it on x86_64-fedora16pre-linux-gnu.
A testcase formerly by me so more sorry than thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2011-11/msg00020.html
--- src/gdb/testsuite/ChangeLog 2011/11/02 23:44:21 1.2923
+++ src/gdb/testsuite/ChangeLog 2011/11/03 17:43:51 1.2924
@@ -1,3 +1,7 @@
+2011-11-03 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/commands.exp (cmd1 error): Fix false ERROR with gdbserver.
+
2011-11-02 Stan Shebs <stan@codesourcery.com>
* gdb.trace/collection.c: Add code using strings.
--- src/gdb/testsuite/gdb.base/commands.exp 2011/08/26 21:45:24 1.45
+++ src/gdb/testsuite/gdb.base/commands.exp 2011/11/03 17:43:51 1.46
@@ -741,7 +741,7 @@
gdb_test_no_output "end" "main commands 2c"
gdb_run_cmd
- gdb_test "" "\r\nhook-stop1\r\n.*\r\ncmd1\r\nUndefined command: \"errorcommandxy\"\\. Try \"help\"\\." "cmd1 error"
+ gdb_test "" "hook-stop1\r\n.*\r\ncmd1\r\nUndefined command: \"errorcommandxy\"\\. Try \"help\"\\." "cmd1 error"
gdb_test {echo idle\n} "\r\nidle" "no cmd2"
}