This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Avoid computing fullname if unused.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 07 Nov 2011 07:48:41 -0700
- Subject: Re: [patch] Avoid computing fullname if unused.
- References: <20111107063715.554F5246194@ruffy.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <firstname.lastname@example.org> writes:
Doug> 2011-11-06 Doug Evans <email@example.com>
Doug> * dwarf2read.c (dw2_map_symbol_filenames): New parameter
Doug> * psymtab.c (map_symbol_filenames_psymtab): Ditto.
Doug> (map_partial_symbol_filenames): Ditto. All callers updated.
Doug> * psymtab.h (map_partial_symbol_filenames): Update prototype.
Doug> * symfile.h (struct quick_symbol_functions, map_symbol_filenames): New
Doug> parameter need_fullname.
Seems reasonable to me.
Ideally these could be computed lazily, but that is a bit of a pain in C.
Doug> + map_partial_symbol_filenames (print_partial_file_name, NULL,
Doug> + TRUE /*need_fullname*/);
I don't think TRUE and FALSE are really part of the gdb style.
gdb tends to just use 0/1 for this.
I'd like us to follow gcc and use 'bool', 'true', and 'false' -- but not
these all-caps spellings.