This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing

From: Pedro Alves <pedro at codesourcery dot com>
To: gdb-patches at sourceware dot org
Cc: "Maciej W. Rozycki" <macro at codesourcery dot com>, Joel Brobecker <brobecker at adacore dot com>, Doug Evans <dje at google dot com>
Date: Sat, 12 Nov 2011 00:08:28 +0000
Subject: Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
References: <alpine.DEB.1.10.1111101340460.4191@tp.orcam.me.uk> <20111111174247.GF5390@adacore.com> <alpine.DEB.1.10.1111111812040.4191@tp.orcam.me.uk>

On Friday 11 November 2011 18:59:10, Maciej W. Rozycki wrote:
>  Well, OOC I looked at the relevant source and the bug (and consequently 
> the fix) is quite obvious -- the debug registers are only actually pushed 
> down to hardware on data breakpoints and not execution breakpoints.

Ugh, my fault...

> 2011-11-11  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	gdb/
> 	* i386-nat.c (i386_insert_hw_breakpoint): Call 
> 	i386_update_inferior_debug_regs.
> 	(i386_remove_hw_breakpoint): Likewise.

Okay.  Thanks!

-- 
Pedro Alves

Follow-Ups:
- Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
  - From: Maciej W. Rozycki

References:
- [PATCH] testsuite: Add (extensive) hardware breakpoint testing
  - From: Maciej W. Rozycki
- Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
  - From: Joel Brobecker
- Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
  - From: Maciej W. Rozycki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]