Re: [PATCH - TUI and Insight Related] Fix for PR13378

[Pedro Alves <pedro at codesourcery dot com>]

On Friday 11 November 2011 20:53:59, Sterling Augustine wrote:
> Hi,
> 
> Enclosed is a very simple patch which fixes the annoying TUI-updating
> issue described in
> http://sourceware.org/bugzilla/show_bug.cgi?id=13378.
> 
> It simply eliminates a call to
> deprecated_selected_frame_level_changed_hook. This hook has been
> deprecated for many years, so one would think it's clients have had
> time to remove the dependency. 

Sorry, this approach is backwards.  We should stop TUI from
installing the hook first instead.  Then when all users have
disappeared, we can eliminate the hook.

> After using it locally for a week now,
> I see no ill effects in TUI. stopping at breakpoints, up, down, and
> the other stuff all work fine for me. However, the testsuite is, err,
> incomplete on this feature.

I've tried it, and that's unfortunately not true -- TUI no longer
reacts to up/down.  

The right fix is adding a new observer for when the user changes the
frame, and make TUI use it instead of this hook that triggers all
too often.  I thought MI had such an observer, but I guess that
was some discussion that never got anywhere or a patch that never
got in.

-- 
Pedro Alves