This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/348] Fix -Wshadow errors


Andrey,

> ---
>  gdb/ada-exp.y |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

This change is OK, but we need a ChangeLog entry for it. As soon as
you've resubmitted it with the ChangeLog entry, we can give you write
access to the GDB repository, and you'll be able to commit the approved
patches yourself.

If you haven't already done so, please read the gdb/CONTRIBUTE file...

Generally speaking, we also expect all changes to be validated against
our testsuite. This means running the testsuite before and after the
patch, and making sure that new failures did not appear in the meantime.

> 
> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
> index 9576be5..bfa3913 100644
> --- a/gdb/ada-exp.y
> +++ b/gdb/ada-exp.y
> @@ -1287,12 +1287,12 @@ write_var_or_type (struct block *block, struct stoken name0)
>  	     FIXME pnh 7/20/2007. */
>  	  if (nsyms == 1)
>  	    {
> -	      struct symbol *renaming =
> +	      struct symbol *ren_sym =
>  		ada_find_renaming_symbol (SYMBOL_LINKAGE_NAME (syms[0].sym), 
>  					  syms[0].block);
>  
> -	      if (renaming != NULL)
> -		syms[0].sym = renaming;
> +	      if (ren_sym != NULL)
> +		syms[0].sym = ren_sym;
>  	    }
>  
>  	  type_sym = select_possible_type_sym (syms, nsyms);
> -- 
> 1.7.5.4
> 


-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]