This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Renesas SH (sh4) native support
2011/11/18 Joel Brobecker <firstname.lastname@example.org>:
> The biggest issue I have besides copyright assignment (from the original
> author, right?) is the fact that it hasn't been tested. If we could
> involve the author a bit, and ask him to rebase the patch against
> HEAD, and test it a bit, at least we could have a little bit of
Surely, before merging the code, it must be built and tested properly.
The original author was CC, but apparently that email was wrong and it
was bouncing the email, so I am adding another known address, and see
if we can add support into main GDB for Renesas SH.
@Yoshii-san, please, look at
> I've also spotted the following:
> Â Â+#include <sys/ptrace.h>
> Â Â+#include <sys/types.h>
> Â Â+#include <sys/param.h>
> Â Â+#include <sys/user.h>
> Â Â+#include <sys/syscall.h>
> Â Â+
> Â Â+#include <asm/ptrace.h>
> which is a big no-no in a -tdep file. Tdep files should be compilable
> on any host.
> I haven't been able to review the file much beyond that...
Thanks for the comments!
ÂHÃctor OrÃn Â-.. . -... .. .- -. Â -.. . ...- . .-.. --- .--. . .-.