This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 22/348] Fix -Wsahdow warnings

On Thu, Nov 24, 2011 at 12:56 AM, Doug Evans <> wrote:

> For reference sake, I did "grep -e -Wall ChangeLog*" to see what's
> been done in the past. ?Based on that there is room for compromise I think.
> Since these are just mechanical changes, and there are a lot of them,
> I'd be happy with a compromise everyone is happy (or at least
> not unhappy :-)) with.
> I think keeping them at the file level is easiest for you (just
> guessing though).
> And I'd be happy with a changelog entry that simply said:
> ? ? ? ?* foo.c: -Wshadow lint.
> or
> ? ? ? ?* foo.c (bar, baz): -Wshadow lint.
> ? ? ? ?(huey,dewey,louie): Ditto.

I changed(after it was pointed out that they do not conform to GNU
policy) the style of my ChangeLog entries to

 ? ? ? ?* 42.c (trillian): Rename zaphod to beeblebrox(-Wshadow).

Hope this is a reasonable compromise everyone would be OK with. If
anyone have any other suggestions -- I'm all ears.

Andrey Smirnov

P.S. Just for the future reference, because English is not my first
language I expect some of the ChangeLog messages to be awkwardly
phrased. If that's the case feel free to nudge me about it and I'll
correct it(please do provide suggestions for correction).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]