This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add the "-info-os" command to MI

On 21/10/2011 9:39 PM, Tom Tromey wrote:
">" == Kwok Cheung Yeung<> writes:

+ { "info-os", { "info os", 1 }, NULL },

I'd prefer a new function specific to MI to do the command-line parsing.

I think this approach should be deprecated and that no new instances go
into the tree.  They unnecessarily link MI to the CLI, making it harder
to change the CLI.


I've now created a new mi_cmd_info_os function to service -info-os, which delegates to info_osdata_command in osdata.c. This is the same backend that 'info os' in the CLI uses, but at least now we don't go through the CLI code.
info_osdata_command now needs to be non-static.



	* (SUBDIR_MI_OBS): Add mi-cmd-info.o.
	(SUBDIR_MI_SRCS): Add mi-cmd-info.c.
	(mi-cmd-info.o): New rule.
	* osdata.h: Add declaration for info_osdata_command.
	* osdata.c (info_osdata_command): Change to non-static.
	* mi/mi-cmds.c (mi_cmds): Add -info-os MI command.
	* mi/mi-cmd-info.c: New.

Attachment: mi_info-os.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]