This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix


> From: Andrey Smirnov <andrew.smirnov@gmail.com>
> Date: Mon, 28 Nov 2011 22:16:36 +0700
> 
> Cause:
>         It is a ALBW type of clash, the first declaration of the
>         variable is at the beginning of the function.
> 
> To ChangeLog:
> 	* amd64-tdep.c (amd64_push_dummy_call): Remove nested
>         definition of `tdep'(-Wshadow).

ok kettenis@

> ---
>  gdb/ChangeLog    |    5 +++++
>  gdb/amd64-tdep.c |    1 -
>  2 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6dbac0d..6e1121d 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
>  2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
>  
> +	* amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
> +	warnings.
> +
> +2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
> +
>  	* amd64-tdep.c (amd64_get_unused_input_int_reg): Fix -Wshadow
>  	warnings.
>  
> diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
> index 29101a4..987f80d 100644
> --- a/gdb/amd64-tdep.c
> +++ b/gdb/amd64-tdep.c
> @@ -878,7 +878,6 @@ amd64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
>    /* Pass "hidden" argument".  */
>    if (struct_return)
>      {
> -      struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
>        /* The "hidden" argument is passed throught the first argument
>           register.  */
>        const int arg_regnum = tdep->call_dummy_integer_regs[0];
> -- 
> 1.7.5.4
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]