This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add the "-info-os" command to MI


On 29/11/2011 7:01 PM, Tom Tromey wrote:
Two nits...

+ { "info-os", { NULL, 0 }, mi_cmd_info_os},

mi_cmd_info_os doesn't seem to be declared anywhere. I think this ought to cause a compilation error.


Oops - I did add a declaration in mi/mi-cmds.h but forgot to include it in the patch. :-)


+ info_osdata_command (argv [0], 0);

No space before the '['.



Fixed.


Kwok


ChangeLog:


gdb/
	* Makefile.in (SUBDIR_MI_OBS): Add mi-cmd-info.o.
	(SUBDIR_MI_SRCS): Add mi-cmd-info.c.
	(mi-cmd-info.o): New rule.
	* osdata.h (info_osdata_command): New declaration.
	* osdata.c (info_osdata_command): Change to non-static.
	* mi/mi-cmds.h (mi_cmd_info_os): New declaration.
	* mi/mi-cmds.c (mi_cmds): Add -info-os MI command.
	* mi/mi-cmd-info.c: New.

Attachment: mi_info-os.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]