RE: [RFC/WIP PATCH 03/14] Flip to set target-async on by default

[Marc Khouzam <marc dot khouzam at ericsson dot com>]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org 
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Monday, November 28, 2011 10:39 AM
> To: gdb-patches@sourceware.org
> Subject: [RFC/WIP PATCH 03/14] Flip to set target-async on by default
> 
> This flips "set target-async" to default to on.  I see no failures
> left with this on x86_64-linux, and there used to be none either
> against gdbserver, but I haven't tried recently.  One thing left to
> decide is what to do with MI.  If the frontend never flips async
> explicitly, should we bother to emulate sync MI output, or can we
> expect that all frontends can and should cope with async on by default
> by now?

I've just caught up with the 1400 GDB emails I had neglected in the last
couple of months so I surely missed some interesting points that may be 
of interested to Eclipse.
But I did catch this one :-)

Eclipse is not ready for a default target-async on.  But that change
wouldn't be very hard to adapt to, so I'll do it anyway for safety.
(As a side note, I would like Eclipse to always use target-async on, 
even for all-stop, but that would be a large change that I don't have
the bandwith to work on.  Besides, we still support GDB back to 6.6,
so we couldn't get rid of the dealing with the sync behavior anyway.)

Marc

> ---
>  gdb/target.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/target.c b/gdb/target.c
> index 3bc4be2..c2aaa7e 100644
> --- a/gdb/target.c
> +++ b/gdb/target.c
> @@ -4259,11 +4259,11 @@ maintenance_print_target_stack (char 
> *cmd, int from_tty)
>  }
>  
>  /* Controls if async mode is permitted.  */
> -int target_async_permitted = 0;
> +int target_async_permitted = 1;
>  
>  /* The set command writes to this variable.  If the inferior is
>     executing, linux_nat_async_permitted is *not* updated.  */
> -static int target_async_permitted_1 = 0;
> +static int target_async_permitted_1 = 1;
>  
>  static void
>  set_maintenance_target_async_permitted (char *args, int from_tty,
> 
>