This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] testsuite: Pass "break" and "continue" exceptions up

On Thu, 1 Dec 2011, Joel Brobecker wrote:

> > 2011-11-11  Maciej W. Rozycki  <>
> > 
> > 	gdb/testsuite/
> >         * lib/gdb.exp (gdb_expect): Pass all the exception conditions up 
> > 	to the caller.
> > 	(gdb_test_multiple): Likewise.
> Not the biggest expert in TCL, but that seems to make sense to me.
> My understanding is that the change can be made independently of
> the dejagnu version, right?

 Yes, using an old version of DejaGNU will merely imply the old semantics 
(i.e. folding the "break" and "continue" exceptions into a mere "return") 
enforced at the lower level by remote_expect; we should therefore not rely 
on correct operation of the exceptions until we've decided we require at 
least DejaGNU 1.5 (in a few years' time I suppose).

 Obviously nothing prominent relies on the old semantics within our test 
suite or the switch would have caused regressions.  I could have missed an 
obscure architecture-specific test case of course or some failure paths 
that are not triggered for successful runs (for obvious reasons these are 
more error prone as they are hopefully ;) less regularly tested than the 
corresponding success paths).  Either of which should be fixed in a 
backward compatible manner by replacing "break" or "continue" with 
"return" where appropriate.

> If that's the case, please go ahead and commit.

 Applied now, thanks for the review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]