This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] testsuite: Pass "break" and "continue" exceptions up
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>, Ben Elliston <bje at air dot net dot au>
- Date: Sat, 3 Dec 2011 00:14:14 +0000
- Subject: Re: [PATCH] testsuite: Pass "break" and "continue" exceptions up
- References: <alpine.DEB.email@example.com> <20111201223312.GA2777@adacore.com>
On Thu, 1 Dec 2011, Joel Brobecker wrote:
> > 2011-11-11 Maciej W. Rozycki <firstname.lastname@example.org>
> > gdb/testsuite/
> > * lib/gdb.exp (gdb_expect): Pass all the exception conditions up
> > to the caller.
> > (gdb_test_multiple): Likewise.
> Not the biggest expert in TCL, but that seems to make sense to me.
> My understanding is that the change can be made independently of
> the dejagnu version, right?
Yes, using an old version of DejaGNU will merely imply the old semantics
(i.e. folding the "break" and "continue" exceptions into a mere "return")
enforced at the lower level by remote_expect; we should therefore not rely
on correct operation of the exceptions until we've decided we require at
least DejaGNU 1.5 (in a few years' time I suppose).
Obviously nothing prominent relies on the old semantics within our test
suite or the switch would have caused regressions. I could have missed an
obscure architecture-specific test case of course or some failure paths
that are not triggered for successful runs (for obvious reasons these are
more error prone as they are hopefully ;) less regularly tested than the
corresponding success paths). Either of which should be fixed in a
backward compatible manner by replacing "break" or "continue" with
"return" where appropriate.
> If that's the case, please go ahead and commit.
Applied now, thanks for the review.