This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 033/238] [misc.] breakpoint.c: -Wshadow fix
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Andrey Smirnov <andrew dot smirnov at gmail dot com>, Pedro Alves <pedro at codesourcery dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, tromey at redhat dot com
- Date: Mon, 5 Dec 2011 12:25:23 +0100
- Subject: Re: [PATCH 033/238] [misc.] breakpoint.c: -Wshadow fix
- References: <email@example.com> <firstname.lastname@example.org>
> Variable in the inner scope shadowed by variable from outer
> one(defined at the beginning of function.
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 1a4974c..69a8782 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -10667,8 +10667,8 @@ update_global_location_list (int should_insert)
> /* ALL_BP_LOCATIONS bp_location has LOC->OWNER always
> non-NULL. */
> - struct breakpoint *b = loc->owner;
> struct bp_location **loc_first_p;
> + b = loc->owner;
> if (b->enable_state == bp_disabled
> || b->enable_state == bp_call_disabled
I looked at it, and it looks fine from a functional point of view.
However, I'd rather have Jan or Pedro, who have modified this function
more often than I have, to weigh in.
Personally, I'm not keen on the fact that a global variable is reused
in the context of a local loop. So I would rather rename the local
variable inside the loop rather than delete the local variable,
and reuse the global one. It makes for a bigger patch, but I think
it's better in the end.