This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.


On Mon, Dec 5, 2011 at 6:30 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> ? ? ? * breakpoint.c (update_static_tracepoint): Rename `sal' to
>> ? ? ? ? ? `sal2'(-Wshadow).
>
> Looks OK to me. But Pedro might comment on the new variable name
> (sal->sal2).

This name change was suggested by Stan, see
http://sourceware.org/ml/gdb-patches/2011-11/msg00609.html

Initially it was sal->las which probably isn't better, so I'll wait
for some consensus to arise on this patch too.

> (weird mis-alignment of the ChangeLog, but I assume that'll be fixed
> by the time it gets inserted in the ChangeLog file).

I have to edit ChangeLog by hands anyway, so the diffs for it are just
the relics of how I initially made commits. To answer your question:
yes it'll either be fixed or I erroneously weirdly mis-align it even
more :)

Andrey Smirnov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]