This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- From: Tom Tromey <tromey at redhat dot com>
- To: iam ahal <hal9000ed2k at gmail dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches at sourceware dot org, eliz at gnu dot org, pmuldoon at redhat dot com, brobecker at adacore dot com, pedro at codesourcery dot com, drow at false dot org, jan dot kratochvil at redhat dot com
- Date: Tue, 06 Dec 2011 13:39:44 -0700
- Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- References: <BANLkTinD+9_Mkug8o2VhZ03L6XSriL_RKQ@mail.gmail.com> <m3oc1kfheh.fsf@redhat.com> <20110627160029.GF20676@adacore.com> <m3sjqt67pe.fsf@fleche.redhat.com> <m3mxh1oa8a.fsf@redhat.com> <CAA18ubJ10sh3pPDLp4V44qY6r6hLU9RqyDi62KuAAtfXJY7Oug@mail.gmail.com> <834o33qlm9.fsf@gnu.org> <CAA18ubJZK7w51Bmwvy7xYXPvHf7e=bbRbdBOqNvZA-PrXJpUsA@mail.gmail.com> <E1Qdhn8-0000fE-TK@fencepost.gnu.org> <CAA18ubJAvwHt-sq8XN98PhC=LSFXPbcy4P1+AVic-G=MNE7R2A@mail.gmail.com> <CAA18ubLBZseSxqjWSk1jH7OeZi06K_o75HKc0CN-_iCAjQ5boA@mail.gmail.com> <83bowq6x7f.fsf@gnu.org> <CAA18ub+ox5kmHu=1qvMkwNfzbCxMdy3M4Z8eKuheaiqyjxJvEg@mail.gmail.com> <m3d3gu77uk.fsf@fleche.redhat.com> <CAA18ubL6ofB9X+2nJC3jUCTEqZBbWL4=wXHgBkOFKJaAOXsiow@mail.gmail.com> <m3vcue1jal.fsf@fleche.redhat.com> <CADPb22TT2eP+pkdTu50EyTsctzWskDz=oShoTDTsrtzF0Qdnzw@mail.gmail.com> <CAA18ubLKqCCsH6H7mj-nK3cjWKS1g_rbJr9EbG8COY3S+GChxQ@mail.gmail.com>
>>>>> "iam" == iam ahal <hal9000ed2k@gmail.com> writes:
iam> Sorry for a late response, unfortunately, I've been busy at work.
No problem. Thanks for following up.
iam> +static const char filename_display_without_comp_directory[] = "without-compilation-directory";
Just to be clear, the patch is contingent on the naming discussion that
is taking place.
iam> +get_filename_display_from_sal (struct symtab_and_line *sal)
How about const struct symtab_and_line *?
iam> + else if (filename_display_string == filename_display_without_comp_directory
iam> + && dirname && dlen && dlen <= strlen (filename)
iam> + && !filename_ncmp (filename, dirname, dlen))
The indentation here looks wrong.
The "&&" should line up underneath "filename_display_string".
iam> + {
iam> + const char *start = filename + dlen;
iam> + const char *result = start;
iam> + while (IS_DIR_SEPARATOR (*result))
Blank line between declarations and code.
The rest looks reasonable to me.
Thanks again.
Tom