This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: remove obsolete comments

I'm checking this in.

I ran across a couple of obsolete comments.  These refer to the old code
for writing objfile data to disk and then mapping it back in.  This code
was removed from the tree many years ago.


2011-12-08  Tom Tromey  <>

	* objfiles.h (struct objfile): Remove obsolete comment.
	* objfiles.c (build_objfile_section_table): Remove obsolete

Index: objfiles.c
RCS file: /cvs/src/src/gdb/objfiles.c,v
retrieving revision 1.132
diff -u -r1.132 objfiles.c
--- objfiles.c	14 Jun 2011 16:49:41 -0000	1.132
+++ objfiles.c	8 Dec 2011 18:07:03 -0000
@@ -162,12 +162,6 @@
 build_objfile_section_table (struct objfile *objfile)
-  /* objfile->sections can be already set when reading a mapped symbol
-     file.  I believe that we do need to rebuild the section table in
-     this case (we rebuild other things derived from the bfd), but we
-     can't free the old one (it's in the objfile_obstack).  So we just
-     waste some memory.  */
   objfile->sections_end = 0;
   bfd_map_over_sections (objfile->obfd,
 			 add_to_objfile_sections, (void *) objfile);
Index: objfiles.h
RCS file: /cvs/src/src/gdb/objfiles.h,v
retrieving revision 1.87
diff -u -r1.87 objfiles.h
--- objfiles.h	11 Oct 2011 12:58:08 -0000	1.87
+++ objfiles.h	8 Dec 2011 18:07:03 -0000
@@ -173,19 +173,9 @@
     /* All struct objfile's are chained together by their next pointers.
-       The global variable "object_files" points to the first link in this
-       chain.
-       FIXME:  There is a problem here if the objfile is reusable, and if
-       multiple users are to be supported.  The problem is that the objfile
-       list is linked through a member of the objfile struct itself, which
-       is only valid for one gdb process.  The list implementation needs to
-       be changed to something like:
-       struct list {struct list *next; struct objfile *objfile};
-       where the list structure is completely maintained separately within
-       each gdb process.  */
+       The program space field "objfiles"  (frequently referenced via
+       the macro "object_files") points to the first link in this
+       chain.  */
     struct objfile *next;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]