This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] s390*: watchpoints regression [repost]

From: Joel Brobecker <brobecker at adacore dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
Date: Sun, 18 Dec 2011 10:21:27 +0400
Subject: Re: [patch] s390*: watchpoints regression [repost]
References: <20111217094753.GA20113@host2.jankratochvil.net> <20111217194454.GA15156@host2.jankratochvil.net> <201112171956.33037.alves.ped@gmail.com> <201112172012.57734.pedro@codesourcery.com>

> +  /* This is the main thread still going through the shell, or, no
> +     watchpoint has been set yet.  */
> +  if (lwp->arch_private == NULL)
> +    return;

Just a really minor nitpick: Would you consider putting the comment
inside the if, instead of just before? I think it'd be slightly clearer
that way.

-- 
Joel

Follow-Ups:
- Re: [patch] s390*: watchpoints regression [repost]
  - From: Jan Kratochvil

References:
- [obv] s390*: Fix build regression, remains execution regression
  - From: Jan Kratochvil
- Re: [patch] s390*: watchpoints regression [repost]
  - From: Jan Kratochvil
- Re: [patch] s390*: watchpoints regression [repost]
  - From: Pedro Alves
- Re: [patch] s390*: watchpoints regression [repost]
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]