This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Python Finish Breakpoints
On Tue, Dec 20, 2011 at 9:38 PM, Tom Tromey <tromey@redhat.com> wrote:
>
> >>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
>
> Kevin> 2011-12-09 ?Kevin Pouget ?<kevin.pouget@st.com>
> Kevin> ?Introduce gdb.FinishBreakpoint in Python
> [...]
>
> One last little thing, in the test suite.
>
> Kevin> diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp
> Kevin> +if $tracelevel then {
> Kevin> + ? ?strace $tracelevel
> Kevin> +}
>
> Here, this needs to check whether shlibs are ok, like:
>
> if {[skip_shlib_tests]} {
> ? ?untested $name.exp
> ? ?return -1
> }
>
> Kevin> +# Start with a fresh gdb.
> Kevin> +clean_restart ${testfile}
>
> After clean_restart you need
>
> gdb_load_shlibs $lib_sl
>
> I think there are a few of these in this .exp file.
>
> I don't think you really needed shared libraries for this test, but now
> that you did it, it is fine.
>
> Patch ok with this fixed up. ?Thanks!
>
> Tom
Great! I'll fix this last bits and commit it in the next few days
Is it okay for 7.4 branch as well ?
Cordially,
Kevin