This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]


> This patch is going to be important for the coming SystemTap patches
> that I plan to submit this week, and I know GDB has a rule to avoid
> premature modification of the code before a patch is posted, but I
> believe this is a good cleanup to have in any case.
[...]
> 2012-01-18  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* parse.c (initialize_expout): New function.
> 	(reallocate_expout): Likewise.
> 	(parse_exp_in_context): Use `initialize_expout' and
> 	`reallocate_expout' when appropriate.

FWIW, it seems OK to me on its own. I like the fact that you made
the initial_size and gdbarch parameters.

The description does seem to mention an argument that has not been
added yet (parser_state PS). I haven't followed the discussion on
the thread, but have we decided to keep "ps" as the name of the
parser_state argument?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]