This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PowerPC 32 with Secure PLT

From: Joel Brobecker <brobecker at adacore dot com>
To: Michael Eager <eager at eagerm dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Wed, 18 Jan 2012 20:49:17 +0400
Subject: Re: [PATCH] PowerPC 32 with Secure PLT
References: <4F163E35.1080505@eagerm.com> <20120118120831.GB31383@adacore.com> <4F16E632.6010102@eagerm.com> <4F16F527.2000800@eagerm.com>

> >>This is an area where I am not sure, but I think it would be better
> >>to use read_memory_typed_address. I think the address type that you
> >>want is: builtin_type (gdbarch)->builtin_func_ptr.
> 
> I think I'd rather leave the size explicit, rather than making
> it indirect (and unclear).  This routine is only for PowerPC 32 and
> the size of the value is always four bytes.

That would be fine with me. You should be able to get rid of the cast,
though. No?

-- 
Joel

Follow-Ups:
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager

References:
- [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Joel Brobecker
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]