New ARI warning Tue Jan 24 11:33:19 UTC 2012

[GDB Administrator <gdbadmin at sourceware dot org>]

6d5
< gdb/ada-lang.c:10786: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/ada-lang.c:10786:	      sprintf (exception_name, ');
48d46
< gdb/arm-linux-tdep.c:926: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/arm-linux-tdep.c:926:/* Linux-specific displaced step instruction copying function.  Detects when
80,82d77
< gdb/c-lang.c:238: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/c-lang.c:238:		  sprintf (octal, ', (int) (value & 0777));
< gdb/c-lang.c:240: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/c-lang.c:240:		  sprintf (octal, ', (long) value);
< gdb/c-lang.c:248: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/c-lang.c:248:		sprintf (octal, ', orig[i] & 0xff);
119a115,136
> gdb/common/buffer.c:51: regression: abort: Do not use abort, instead use internal_error; GDB should never abort
gdb/common/buffer.c:51:    abort ();
> gdb/common/buffer.c:111: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:111:	      sprintf (str, ', va_arg (ap, int));
> gdb/common/buffer.c:114: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:114:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/common/buffer.c:117: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:117:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/common/buffer.c:120: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:120:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/common/common-utils.c:129: regression: vasprintf: Do not use vasprintf(), instead use xstrvprintf
gdb/common/common-utils.c:129:  int status = vasprintf (&ret, format, ap);
> gdb/common/common-utils.c:141: regression: xasprintf: Do not use xasprintf(), instead use xstrprintf
gdb/common/common-utils.c:141:xasprintf (char **ret, const char *format, ...)
> gdb/common/common-utils.c:151: regression: xvasprintf: Do not use xvasprintf(), instead use xstrvprintf
gdb/common/common-utils.c:151:xvasprintf (char **ret, const char *format, va_list ap)
> gdb/common/common-utils.h:48: regression: xasprintf: Do not use xasprintf(), instead use xstrprintf
gdb/common/common-utils.h:48:void xasprintf (char **ret, const char *format, ...)
> gdb/common/common-utils.h:50: regression: xvasprintf: Do not use xvasprintf(), instead use xstrvprintf
gdb/common/common-utils.h:50:void xvasprintf (char **ret, const char *format, va_list ap)
> gdb/common/gdb_assert.h:46: regression: __func__: Do not use __func__, ISO C 90 does not support this macro
gdb/common/gdb_assert.h:46:#define ASSERT_FUNCTION		__func__
> gdb/common/linux-osdata.c:1: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/common/linux-osdata.c:1:/* Linux-specific functions to retrieve OS data.
> gdb/common/linux-osdata.c:29: regression: stat.h: Do not include stat.h or sys/stat.h, instead include gdb_stat.h
gdb/common/linux-osdata.c:29:#include <sys/stat.h>
> gdb/common/linux-osdata.c:30: regression: dirent.h: Do not include dirent.h, instead include gdb_dirent.h
gdb/common/linux-osdata.c:30:#include <dirent.h>
> gdb/common/linux-osdata.c:62: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/linux-osdata.c:62:  sprintf (filename, ',
> gdb/common/linux-osdata.c:219: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/linux-osdata.c:219:  sprintf (procentry, ', pid);
> gdb/common/linux-osdata.c:260: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/linux-osdata.c:260:  sprintf (taskdir, ', pid);
> gdb/common/linux-osdata.c:348: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/linux-osdata.c:348:		    sprintf (core_str, ', i);
> gdb/common/linux-osdata.c:433: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/linux-osdata.c:433:	      sprintf (procentry, ', dp->d_name);
> gdb/common/linux-osdata.h:1: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/common/linux-osdata.h:1:/* Linux-specific functions to retrieve OS data.
> gdb/common/linux-procfs.c:1: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/common/linux-procfs.c:1:/* Linux-specific PROCFS manipulation routines.
> gdb/common/linux-procfs.h:1: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/common/linux-procfs.h:1:/* Linux-specific PROCFS manipulation routines.
203,205d219
< gdb/dwarf2-frame.c:1436: obsolete: get_frame_base: Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address.
gdb/dwarf2-frame.c:1436:  return get_frame_base (this_frame);
< gdb/dwarf2loc.c:1104: obsolete: get_frame_base: Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address.
gdb/dwarf2loc.c:1104:  ctx->get_frame_base = dwarf_expr_frame_base;
< gdb/dwarf2loc.c:1353: obsolete: get_frame_base: Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address.
gdb/dwarf2loc.c:1353:  ctx->get_frame_base = needs_frame_frame_base;
206a221
> gdb/dwarf2read.c:5647: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/dwarf2read.c:5647:handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu,			const char *comp_dir, int want_line_info)
383d397
< gdb/infrun.c:4404: deprecate: SOLIB_ADD: Replace SOLIB_ADD with nothing, not needed?
gdb/infrun.c:4404:#if defined(SOLIB_ADD)
410c424
< gdb/jit.c:44: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/jit.c:44:jit_inferior_init (struct gdbarch *gdbarch);
> gdb/jit.c:997: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/jit.c:997:  value->defined = frame_register_read (priv->this_frame, gdb_reg,
434,437d447
< gdb/linespec.c:456: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/linespec.c:456:      sprintf (canonical_name, ', filename, symname);
< gdb/linespec.c:461: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/linespec.c:461:      sprintf (canonical_name, ', filename, sal->line);
< gdb/linespec.c:1519: code: OP eol: Do not use &&, or || at the end of a line
gdb/linespec.c:1519:  if (sym_class &&
< gdb/linespec.c:1522: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/linespec.c:1522:  if (sym_class &&      (t = check_typedef (SYMBOL_TYPE (sym_class)),       (TYPE_CODE (t) == TYPE_CODE_STRUCT	|| TYPE_CODE (t) == TYPE_CODE_UNION)))
443a454
> gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/linux-nat.c:3424:	     other than the leader exec'd.  On an exec, the Linux
468,469d478
< gdb/linux-nat.c:5149: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/linux-nat.c:5149:	      sprintf (procentry, ', dp->d_name);
< gdb/linux-nat.c:5161: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/linux-nat.c:5161:		  if ((f = fopen (pathname, ')) != NULL)
586d594
< gdb/nto-tdep.c:262: code: UCASE function: Function name is uppercase.
gdb/nto-tdep.c:262:LM_ADDR (struct so_list *so)
684,686d691
< gdb/procfs.c:4478: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:4478:    if (signal_stop_state  (target_signal_from_host (signo)) == 0 &&
< gdb/procfs.c:4479: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:4479:	signal_print_state (target_signal_from_host (signo)) == 0 &&
< gdb/procfs.c:4496: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:4496:  if (proc_get_traced_signals (pi, &signals) &&
699a705
> gdb/python/py-finishbreakpoint.c:280: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/python/py-finishbreakpoint.c:280:      sprintf (small_buf, ', hex_string (finish_pc));
737a744
> gdb/remote.c:7745: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:7745:      sprintf (p, ', bp_tgt->placed_size);
751a759,760
> gdb/remote.c:10096: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:10096:  sprintf (rs->buf, ', location->owner->number, addr_buf);
> gdb/remote.c:10112: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:10112:  sprintf (rs->buf, ', location->owner->number, addr_buf);
761a771,773
> gdb/remote.c:10456: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:10456:      sprintf (rs->buf, ', val);
> gdb/remote.c:10484: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:10484:  sprintf (rs->buf, ', val);
> gdb/remote.c:10524: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/remote.c:10524:  sprintf (rs->buf, ');
832,833c844
< gdb/s390-tdep.c:2993: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/s390-tdep.c:2993:  /* Initialize the Linux target descriptions.  */
< gdb/s390-tdep.h:114: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/s390-tdep.h:114:/* Linux target descriptions.  */
> gdb/s390-tdep.c:3153: deprecate: write_pc: Replace write_pc() with get_frame_base_address or get_frame_id; at present the inferior function call code still uses this when doing a DECR_PC_AFTER_BREAK
gdb/s390-tdep.c:3153:  set_gdbarch_write_pc (gdbarch, s390_write_pc);
gdb/s390-tdep.c:3153:  set_gdbarch_write_pc (gdbarch, s390_write_pc);
865,867d875
< gdb/solib-sunos.c:142: code: UCASE function: Function name is uppercase.
gdb/solib-sunos.c:142:LM_ADDR (struct so_list *so)
< gdb/solib-sunos.c:153: code: UCASE function: Function name is uppercase.
gdb/solib-sunos.c:153:LM_NEXT (struct so_list *so)
< gdb/solib-sunos.c:165: code: UCASE function: Function name is uppercase.
gdb/solib-sunos.c:165:LM_NAME (struct so_list *so)
869,876d876
< gdb/solib-svr4.c:146: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:146:LM_ADDR_FROM_LINK_MAP (struct so_list *so)
< gdb/solib-svr4.c:156: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:156:HAS_LM_DYNAMIC_FROM_LINK_MAP (void)
< gdb/solib-svr4.c:164: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:164:LM_DYNAMIC_FROM_LINK_MAP (struct so_list *so)
< gdb/solib-svr4.c:174: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:174:LM_ADDR_CHECK (struct so_list *so, bfd *abfd)
< gdb/solib-svr4.c:265: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:265:LM_NEXT (struct so_list *so)
< gdb/solib-svr4.c:275: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:275:LM_PREV (struct so_list *so)
< gdb/solib-svr4.c:285: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:285:LM_NAME (struct so_list *so)
< gdb/solib-svr4.c:295: code: UCASE function: Function name is uppercase.
gdb/solib-svr4.c:295:IGNORE_FIRST_LINK_MAP_ENTRY (struct so_list *so)
931d930
< gdb/symtab.c:3092: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/symtab.c:3092:      if (0 != (val = re_comp (regexp)))
997a997,998
> gdb/tracepoint.c:1801: gettext: _ markup: All messages should be marked up with _.
gdb/tracepoint.c:1801:    warning ("Target does not support trace user/notes, info ignored");
> gdb/tracepoint.c:1861: gettext: _ markup: All messages should be marked up with _.
gdb/tracepoint.c:1861:    warning ("Target does not support trace notes, note ignored");
1002,1004c1003,1005
< gdb/tracepoint.c:3178: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tracepoint.c:3178:      sprintf (buf, ', namebase);
< gdb/tracepoint.c:3183: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tracepoint.c:3183:      sprintf (buf, ', namebase, try_num++);
< gdb/tracepoint.c:3189: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tracepoint.c:3189:    sprintf (buf, ', namebase, try_num++);
> gdb/tracepoint.c:3169: gettext: _ markup: All messages should be marked up with _.
gdb/tracepoint.c:3169:    warning ("Target does not support trace notes, user ignored");
> gdb/tracepoint.c:3181: gettext: _ markup: All messages should be marked up with _.
gdb/tracepoint.c:3181:    warning ("Target does not support trace notes, note ignored");
> gdb/tracepoint.c:3193: gettext: _ markup: All messages should be marked up with _.
gdb/tracepoint.c:3193:    warning ("Target does not support trace notes, stop note ignored");
1069a1071
> gdb/valops.c:2633: deprecated: deprecated set_value_type: Do not use deprecated set_value_type, see declaration for details
gdb/valops.c:2633:	deprecated_set_value_type (args[0],
1072c1074,1076
< gdb/valops.c:3613: deprecated: deprecated safe_get_selected_frame: Do not use deprecated safe_get_selected_frame, see declaration for details
gdb/valops.c:3613:      frame = deprecated_safe_get_selected_frame ();
> gdb/valprint.c:1569: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/valprint.c:1569:		  sprintf (octal, ', (int) (value & 0777));
> gdb/valprint.c:1571: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/valprint.c:1571:		  sprintf (octal, ', (long) value);
> gdb/valprint.c:1579: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/valprint.c:1579:		sprintf (octal, ', orig[i] & 0xff);
1129d1132
< gdb/xcoffread.c:1588: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/xcoffread.c:1588:	  if (*name == '.' || (pp = (char *) strchr (name, '.')) == NULL)
1150,1153c1153,1157
< gdb/xstormy16-tdep.c:268: code: OP eol: Do not use &&, or || at the end of a line
gdb/xstormy16-tdep.c:268:						  typelen - j ==
< gdb/xtensa-tdep.c:327: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/xtensa-tdep.c:327:		  sprintf (name, ', size * 8);
< gdb/xtensa-tdep.c:846: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/xtensa-tdep.c:846:  if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0)
< gdb/xtensa-tdep.c:2719: code: OP eol: Do not use &&, or || at the end of a line
gdb/xtensa-tdep.c:2719:	   (i < C0_NREGS) &&
> gdb/utils.c:0: internal: gdb/utils.c missing xasprintf: Expecting 1 occurances of bug xasprintf in file gdb/utils.c, only found 0
gdb/utils.c:0:
gdb/utils.c:0:
gdb/utils.c:0:
> gdb/defs.h:0: internal: gdb/defs.h missing xvasprintf: Expecting 1 occurances of bug xvasprintf in file gdb/defs.h, only found 0
gdb/defs.h:0:
gdb/defs.h:0:
> gdb/utils.c:0: internal: gdb/utils.c missing vasprintf: Expecting 1 occurances of bug vasprintf in file gdb/utils.c, only found 0
gdb/utils.c:0:
gdb/utils.c:0:
gdb/utils.c:0:
> gdb/defs.h:0: internal: gdb/defs.h missing xasprintf: Expecting 1 occurances of bug xasprintf in file gdb/defs.h, only found 0
gdb/defs.h:0:
gdb/defs.h:0:
> gdb/utils.c:0: internal: gdb/utils.c missing xvasprintf: Expecting 1 occurances of bug xvasprintf in file gdb/utils.c, only found 0
gdb/utils.c:0:
gdb/utils.c:0:
gdb/utils.c:0: