This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [10/10] watchpoint.exp: Run tests twice: once with hw watchpoints enabled; another time with hw watchpoints disabled.
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 26 Jan 2012 11:05:25 -0700
- Subject: Re: [10/10] watchpoint.exp: Run tests twice: once with hw watchpoints enabled; another time with hw watchpoints disabled.
- References: <4F215EE8.4080302@redhat.com> <4F216252.70901@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Finally, this makes tests that can run with or without hw
Pedro> watchpoints run twice, on targets that can do hw watchpoints.
Pedro> +# True if we're forcing no hardware watchpoints.
Pedro> +set no_hw 0
Pedro> +
Pedro> # Prepare for watchpoint tests by setting up two breakpoints and one
Pedro> # watchpoint.
Pedro> #
Pedro> @@ -97,6 +100,10 @@ proc maybe_clean_restart { } {
Pedro> global testfile
Pedro> clean_restart $testfile
Pedro> +
Pedro> + if {$no_hw} {
I think maybe_clean_restart needs "global no_hw".
I didn't see it elsewhere in the patches.
Pedro> @@ -108,6 +115,11 @@ proc maybe_reinitialize { } {
Pedro> global testfile
Pedro> clean_restart $testfile
Pedro> +
Pedro> + if {$no_hw} {
Ditto.
Tom