This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp

On 01/30/2012 07:13 AM, Joel Brobecker wrote:
> Thanks for spotting the missing changes...
> 
>> On Mon, 30 Jan 2012 07:55:22 +0100, Joel Brobecker wrote:
>>> unless there are better naming suggestions?
>>
>> Maybe "la_get_symbol_name_no_match"?  As you note yourself:
> 
> It's an interesting suggestion, but it introduces double-negatives,
> and I'd rather not do that.

Did you consider keeping the name, but reverse the return logic to
be what one would expect instead (return true/false for match)?

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]