This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp

On 01/30/2012 11:36 AM, Joel Brobecker wrote:
>> Did you consider keeping the name, but reverse the return logic to
>> be what one would expect instead (return true/false for match)?
> 
> I did. But the cost is that we cannot use strcmp* as default matching
> routines. We end up needing a wrapper, which isn't great and also
> costs us an extra function call.

Okay.  Not sure whether the wrapper/call makes a real difference,
but in any case, la_get_symbol_name_cmp makes sense and looks fine
to me.  (I find "no_match" confusing.)

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]