This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix PR python/13599
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 31 Jan 2012 15:22:45 -0800
- Subject: Re: RFA: fix PR python/13599
- References: <m3y5sncz08.fsf@fleche.redhat.com>
On Tue, Jan 31, 2012 at 2:01 PM, Tom Tromey <tromey@redhat.com> wrote:
> This fixes PR python/13599.
>
> The bug is that there is no way to get the line number in the source at
> which a symbol was defined, even though gdb tracks this information.
>
> This patch changes gdb.Symbol to add a new 'line' attribute.
>
> This requires a doc review.
>
> Built and regtested on x86-64 Fedora 15.
>
> Tom
>
> 2012-01-31 ?Tom Tromey ?<tromey@redhat.com>
>
> ? ? ? ?PR python/13599:
> ? ? ? ?* python/py-symbol.c (sympy_line): New function.
> ? ? ? ?(symbol_object_getset): Add "line".
'tis ok with me.
One comment though.
The first thing that come to mind, as a user, is "Well, if I can get
the line number from the symbol, why do I have to look elsewhere to
get the file name?"
The reason is an internal gdb implementation detail that we expose in
python. IWBN if symbol tables were more nebulous entities - we might
want the freedom to change them a bit. [Not that we necessarily can
change things now, but I think it's something we should keep in mind.]