[commit] Re: [RFA take 2] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738))

[Gary Benson <gbenson at redhat dot com>]

Jan Kratochvil wrote:
> On Mon, 30 Jan 2012 15:58:34 +0100, Gary Benson wrote:
> > Updated patch attached.
> 
> It is (up to few exceptions as I see) standard in GDB rather than:
>    typedef int (*symbol_found_callback_ftype) (struct symbol *sym, void *data);
> to do:
>    typedef int (symbol_found_callback_ftype) (struct symbol *sym, void *data);
> 
> and then everywhere change:
>    			  symbol_found_callback_ftype callback,
> ->
>    			  symbol_found_callback_ftype *callback,
> 
> It is not covered by the coding rules, though.
> 
> > Is this ok to commit?
> 
> With that change yes.

I have committed this, with one extra modification in that I moved the
new symbol_found_callback_ftype typedef from language.h to symtab.h.

Cheers,
Gary

--
http://gbenson.net/

Attachment: patch
Description: Text document