This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"

From: Sterling Augustine <saugustine at google dot com>
To: gdb-patches at sourceware dot org
Date: Fri, 17 Feb 2012 15:54:52 -0800
Subject: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
Authentication-results: mr.google.com; spf=pass (google.com: domain of saugustine@google.com designates 10.229.102.72 as permitted sender) smtp.mail=saugustine@google.com; dkim=pass header.i=saugustine@google.com

The enclosed one-line fix for bug 13689 simply adds UNOP_CAST as a
known unary operator to the function watchpoint_exp_is_constant. So
instead of being conservative and guessing that the expression can
change, the function continues its analysis. This is identical
handling to the other unary operators.

OK to check in?

Sterling

2012-02-17  Sterling Augustine  <saugustine@google.com>

	PR 13689:
	* breakpoint.c (watch_exp_is_constant): Add UNOP_CAST to switch.

Attachment: bug_13689.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]