This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"

From: Joel Brobecker <brobecker at adacore dot com>
To: Sterling Augustine <saugustine at google dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 22 Feb 2012 08:18:49 -0800
Subject: Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
References: <CAEG7qUxxtvZ1q_3c2-SJJW+fWMdxZ1tg7nHWrDYVaPq=o5Btfg@mail.gmail.com> <20120218171844.GA2692@adacore.com> <CAEG7qUwFZFjuwc=9iMs9hJ3JAouD2_3hsuxHzAVTMqAVsccc=g@mail.gmail.com>

> 2012-02-17  Sterling Augustine  <saugustine@google.com>
> 
> 	PR 13689:
> 	* breakpoint.c (watchpoint_exp_is_constant): Add UNOP_CAST to switch.

Thanks again. You're missing a ChangeLog entry for the testsuite change,
but everything otherwise looks good to me. Please add one and then commit.

-- 
Joel

References:
- [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
  - From: Sterling Augustine
- Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
  - From: Joel Brobecker
- Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"
  - From: Sterling Augustine

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]