This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Assert when 'break' with no arguments

On 02/14/2012 08:44 PM, Aleksandar Ristovski wrote:
> --- gdb/stack.c	7 Feb 2012 04:48:22 -0000	1.247
> +++ gdb/stack.c	14 Feb 2012 20:43:08 -0000
> @@ -909,6 +909,11 @@ set_last_displayed_sal (int valid, struc
>    last_displayed_addr = addr;
>    last_displayed_symtab = symtab;
>    last_displayed_line = line;
> +  if (valid && pspace == NULL)
> +    {
> +      warning (_("Trying to set NULL pspace."));

Is there a case when this isn't a gdb bug?  IOW, any reason this isn't a gdb_assert?
This seems like a rather cryptic warning to show to a user.

> +      clear_last_displayed_sal ();
> +    }
>  }
>  


-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]