This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>, Doug Evans <dje at google dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 28 Feb 2012 19:42:36 +0000
- Subject: Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
- References: <alpine.DEB.1.10.1111101340460.4191@tp.orcam.me.uk> <CADPb22Qe6G76gDRkVtXhzOhR0w+3VsC9=-eHt-aM=1w8+V7qPg@mail.gmail.com> <alpine.DEB.1.10.1111111907260.4191@tp.orcam.me.uk> <alpine.DEB.1.10.1112081529330.5354@tp.orcam.me.uk> <alpine.DEB.1.10.1202272056010.4811@tp.orcam.me.uk> <4F4D0B18.5040402@redhat.com>
On Tue, 28 Feb 2012, Pedro Alves wrote:
> I read the thread from the start, and I diffed the new proposed test against break.exp,
> and I think we should go ahead and put this in. Only a couple remarks below.
>
> > +# Copyright 2012 Free Software Foundation, Inc.
>
> I think dropping the original copyright years was a mistake.
TBH I've never been particularly convinced to do that since this is
derived work (and clearly not in a trivial amount). Thanks for backing me
up.
> > +if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } {
>
> s/"break"/"hbreak2", so that running this test doesn't overwrite break.exp's binary.
> More instances of this.
Good point, apparently there is just one other place requiring this
adjustment.
Thanks for your review, here's the resulting update. Any further
thoughts, anyone?
Maciej
Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/hbreak2.exp
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.base/hbreak2.exp 2012-02-28 18:50:20.455581421 +0000
+++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/hbreak2.exp 2012-02-28 18:49:31.835596342 +0000
@@ -1,4 +1,5 @@
-# Copyright 2012 Free Software Foundation, Inc.
+# Copyright 1988, 1990-1992, 1994-2000, 2002-2003, 2007-2012 Free
+# Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -19,7 +20,7 @@
# the number available.
-if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } {
+if { [prepare_for_testing hbreak2.exp "hbreak2" {break.c break1.c} {debug nowarnings}] } {
return -1
}
set srcfile break.c
@@ -530,7 +531,7 @@ test_next_with_recursion
# Build a new file with optimization enabled so that we can try breakpoints
# on targets with optimized prologues.
-if { [prepare_for_testing hbreak2.exp "breako2" {break.c break1.c} {debug nowarnings optimize=-O2}] } {
+if { [prepare_for_testing hbreak2.exp "hbreak2o2" {break.c break1.c} {debug nowarnings optimize=-O2}] } {
return -1
}