This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Sort overload menu (decode_line_2)
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Joel> Just a question, wondering if that matters at all. Do we have a
Joel> convention for indentation in TCL/expect files? I am sort of used
Joel> to using 4 spaces, although I couldn't really care less.
Keith> As much as I try, I keep forgetting to check this. My editor is set to
Keith> the standard that I use in insight, which is a mix of four- and
Keith> two-space indents. I've updated the patches accordingly (they might
Keith> still contain tabs).
We do use 4 spaces. I think tabs are fine, or anyhow Joel hasn't yet
pushed hard enough for us to stop using them :)
I put this in src/../.dir-locals.el, to make Emacs automatically pick
the right settings for our Tcl code, and to make bug-reference-mode
work:
((tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)))
(nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s";)))
)
We could put it in src/gdb/ instead if people wanted.
Keith> For the cleanup:
Keith> testsuite/ChangeLog
Keith> 2012-02-28 Keith Seitz <keiths@redhat.com>
Keith> * gdb.cp/method2.exp: Use prepare_for_testing and cleanup
Keith> some Tcl syntax.
Keith> * gdb.cp/ovldbreak.exp: Likewise.
This is ok. Thanks.
Keith> For the menu-sorting patch:
Keith> ChangeLog
[...]
Keith> +# This is a list of the actual overloaded method arugments.
Typo, "arguments".
This patch is ok with that fix :)
Tom