Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-*

[Doug Evans <dje at google dot com>]

On Tue, Apr 3, 2012 at 11:33 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>> > ?gdb-scripts: ?Canned sequences of commands auto-loading is on.
>> > ?libthread-db: ?Inferior specific libthread_db auto-loading is on.
>> > -local-gdbinit: ?Current directory .gdbinit script auto-loading is on.
>> > +local-gdbinit: ?Current directory .gdbinit script auto-loading is yes.
>>
>> Why "yes"?
>
> parse_binary_operation accepts any of 'on', '1', 'yes' or 'enable' (and sure
> off/0/no/disable). ?It then displays the boolean only as "on" and "off".
>
> Somehow it seems more appropriate for these auto-loading settings to use
> yes/no instead of on/off. ?This is also why I use yes/no in the documentation.
> When I added the warning option I had to choose only one pair, therefore
> I chose yes/no. ?But this means the default displayed boolean values are new
> yes/no (and not on/off). ?It also means it no longer accepts the alternative
> words on/1/enable (and off/0/disable); but that is not a real regression when
> the setting never existed before this patchset.

"on" reads much better to me.

> There are two possibilities:
> ?* Introduce new option some "set local-gdbinit-warning <boolean>" as
> ? suggested by Doug IIUC and technically keep everything boolean.

For completeness sake,
I was suggesting making the option more general, applying to more to
more than just local-gdbinit (assuming more applications were readily
available).

> ?* Switch the words used in documentation from yes/no to on/off, therefore
> ? also make the switch on/off/warn-and-on/warn-and-off.