This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[cancel] [patch] More suggestive error_is_running message
On Wed, 11 Apr 2012 17:25:31 +0200, Joel Brobecker wrote:
> > error (_("Cannot execute this command while "
> > - "the selected thread is running."));
> > + "the selected thread is running. "
> > + "(You may want to use 'interrupt' "
> > + "and wait for '[Thread N] #1 stopped.'.)"));
> > }
>
> Just my two cents on this, I don't really have a strong opinion.
>
> I'd put the new output on a second line,
OK, I see error is already being used with embedded \n.
> I think that it's OK to drop the part that talks about waiting for the stop
> notification. Once you've used it once, you'll know,
The whole point of my patch was not notify about the _wait_, not about the
_interrupt_, as this is what one cannot easily catch when debugging a testcase
after converting it full-stop -> non-stop. If you try to reproduce the
problem by hand it works. OK, I admit I am too stupid to write GDB testcases.
Thanks,
Jan