This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Check code stype in Emacs: gdb-code-style.el
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 16 Apr 2012 12:17:36 -0600
- Subject: Re: [PATCH] Check code stype in Emacs: gdb-code-style.el
- References: <1334378614-13787-1-git-send-email-yao@codesourcery.com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> gdb-code-style.el gives some checks, and highlight corresponding parts
Yao> if they are violations on a certain rule or convention in gdb development.
Yao> So far, it only has two, and I'd like to push more, if it is the right
Yao> way to go.
Super, let's do it.
Yao> diff --git a/gdb/gdb-code-style.el b/gdb/gdb-code-style.el
Yao> new file mode 100644
Yao> index 0000000..5919e3d
Yao> --- /dev/null
Yao> +++ b/gdb/gdb-code-style.el
Yao> @@ -0,0 +1,35 @@
Yao> +;; Emacs settings to check various code styles.
Yao> +;; Copyright (C) 2012 Free Software Foundation, Inc.
Could you make this conform to the elisp comment-header guidelines?
See (info "(elisp) Library Headers").
With this change people can M-x package-install-file the .el if they
want. (In fact that is a decent way to test the headers; package.el is
kind of picky about the formatting.)
Ok with that change.
Tom