Re: [PATCH v2] Add autoload-breakpoints [6/6] autoload-breakpoints doc

[Hui Zhu <hui_zhu at mentor dot com>]

On 04/19/12 02:53, Eli Zaretskii wrote:
> > Date: Wed, 18 Apr 2012 18:53:46 +0800
> > From: Hui Zhu<hui_zhu@mentor.com>
> >
> > +about autoload-breakpints from the stub.
>                    ^^^^^^^^^^
> A typo.
>
> > +enable or disable it.  @value{GDBN} will create this breakpoint as
> > +it have been created in the target.  So when the target create the
> > +breakpoint, it need insert this breakpoint with itself. ^^^^^^
>                    ^^^^^^^^^^^                 ^^^^^^^^^^^
> "creates", "needs to insert", and "by itself".
>
> > +@item @var{id}@samp{:}@samp{R}
> > +This is the remove packet.
> > +@var{id} is the number of the autoload-breakpoint that this command
> > +wants to remove, encoded as a hex string.
> > +@value{GDBN} will remove this breakpoint as it have been removed in
> > +the target.
>
> I don't understand the last sentence.  Please explain.
>
> >               So when the target remove the breakpoint, it need remove
> > +this breakpoint with itself.   ^^^^^^                    ^^^^^^^^^^^
>                     ^^^^^^^^^^^
> "removes", "needs to remove", and "by itself".
>
> By the way, what non-trivial information does this sentence convey?
> It seems to say "when the target removes the breakpoint, it needs to
> remove the breakpoint", which is trivial.  What am I missing here?

This part is not very clear.  What about following part?

When @value{GDBN} get this packet, it will delete this breakpoint
as it have been removed in the target.  So when the target send
this packet, it needs to remove these breakpoints in local part by itself.

> > +0 means all autoload-breakpoints.
>
> This sentence should be moved right after the sentence that starts
> with "@var{id} is the number of the autoload-breakpoint".
>
> Thanks.

Thanks,
Hui

2012-04-19  Hui Zhu  <hui_zhu@mentor.com>

	* gdb.texinfo (Setting Breakpoints): Add set breakpoint autoload.
	(Remote Serial Protocol): Add Autoload-breakpoints Format.

Attachment: autoload-breakpoints-doc.txt
Description: Text document