This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH/MIPS] Add support Octeon's bbit instructions

From: Joel Brobecker <brobecker at adacore dot com>
To: "Pinski, Andrew" <Andrew dot Pinski at caviumnetworks dot com>
Cc: "Maciej W. Rozycki" <macro at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "pinskia at gmail dot com" <pinskia at gmail dot com>
Date: Fri, 20 Apr 2012 16:35:46 -0700
Subject: Re: [PATCH/MIPS] Add support Octeon's bbit instructions
References: <CA+=Sn1mwHXVa7_-ktwgQVNq2ZyX8bQEjhj95ZbyWpTbVGPQixg@mail.gmail.com> <alpine.DEB.1.10.1204191322460.19835@tp.orcam.me.uk> <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local>

Hi Andrew,

This is a superficial review, I was just glancing at the diff
for no real reason when I spotted a couple of little nits. They
may be specific to the GDB project...

> +/* Return nonzero if the gdbarch is an Octeon series. */
> +static int
> +is_octeon (struct gdbarch *gdbarch)

We'd like to have one empty line between the function documentation
and its declaration.  Also, 2 spaces after the period :-).

-- 
Joel

References:
- [PATCH/MIPS] Add support Octeon's bbit instructions
  - From: Andrew Pinski
- Re: [PATCH/MIPS] Add support Octeon's bbit instructions
  - From: Maciej W. Rozycki
- RE: [PATCH/MIPS] Add support Octeon's bbit instructions
  - From: Pinski, Andrew

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]