This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)


On Tue, Apr 24, 2012 at 10:42 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> a) How's the ChangeLog for this patch supposed to be? ?Can I make a
> Sergio> "generic" ChangeLog, saying something like `Remove unused variables from
> Sergio> files'?
>
> I'm afraid I will leave that question for someone who cares a bit more.
> Sorry about that.

fwiw, I'm all for not having to follow the rules that would impose
excessive typing in such cases.
There is precedent for, at least in whitespace cases, just listing the files.
I'm happy with that.  So while you would have to list the files
touched, at least you wouldn't have to document the functions!

[One doesn't always have to list the files that are touched.  A common
case is when you change the signature of a function and then say "All
callers updated."
However, that feels different enough that I have a preference for
listing the files touched in global cleanup operations.]

E.g.
        * foo.c: Mumble.
        * bar.c: Likewise.
        * baz.c: Likewise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]