This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Check style of mark up and comment
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 26 Apr 2012 09:56:30 -0600
- Subject: Re: [PATCH] Check style of mark up and comment
- References: <1335359660-25269-1-git-send-email-yao@codesourcery.com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> This patch adds two new hooks to check markup and comment style.
Yao> Missing marker up and incorrect comment style are the most common
Yao> mistakes found in review. It is useful to check them when writing
Yao> code.
Thanks.
Yao> + '(("\\<warning[ ]*\\(\([^_]\\)" 1 font-lock-warning-face t))))
Should 'error' be there as well?
Yao> + ;; A space shoud follow "/*", otherwise report a warning.
Typo: "should".
This patch is ok with the typo fix. It is also ok if you want to add
"error", up to you.
Tom