This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
- From: Pedro Alves <palves at redhat dot com>
- To: Will Deacon <will dot deacon at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 26 Apr 2012 17:02:18 +0100
- Subject: Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
- References: <1335455675-1453-1-git-send-email-will.deacon@arm.com>
On 04/26/2012 04:54 PM, Will Deacon wrote:
> When debugging a uclinux target, it is necessary to retrieve the text
> and data offsets of the running program in order for symbol resolution
> to work correctly.
>
> This patch pulls in definitions for PT_{TEXT,DATA,TEXT_END}_ADDR from
> the kernel's exported ptrace header, which can be issued as `magic'
> addresses to the PTRACE_PEEKUSER request in order to retrieve the child
> offsets.
> ---
>
> 2012-04-17 Will Deacon <will.deacon@arm.com>
>
> * linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and
> PT_DATA_ADDR definitions from asm/ptrace.h.
>
> gdb/gdbserver/linux-low.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index 35d7e69..93d1f36 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -4772,6 +4772,8 @@ linux_stopped_data_address (void)
> #define PT_TEXT_ADDR (0x10000*4)
> #define PT_DATA_ADDR (0x10004*4)
> #define PT_TEXT_END_ADDR (0x10008*4)
> +#else
> +#include <asm/ptrace.h>
> #endif
I'd much rather we include asm/ptrace.h unconditionally at the top, and wrap the
existing #defines in (a single) #ifndef PT_TEXT_ADDR. That'll allow easily trimming
that section in a few years time, if/when we bump the minimum kernel version
required past a version that is known to define those for those archs. If that breaks
one of those archs, we'll hear about it soon enough, don't sweat about it. :-)
--
Pedro Alves