This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method.
> > +/* Implement the push_dummy_code gdbarch method for mips targets. */
>
> I notice people have been adding this style of comment in some other
> newly contributed targets. Do people really feel that having these is
> useful? If so, can we at least settle on a consitent style?
I think they are useful, because they allow us to tell people that
new functions should ALL be documented, even the obvious ones
that are used to implement a given hook. And since we do not
want to repeat the hook's documentation, this tells the reader
where to look.
I am happy to standardize on any format, as long as we all agree.
I will adjust the two style issues that you pointed out.
Thank Mark.
--
Joel