This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: John Steele Scott <toojays at toojays dot net>
- Cc: Tom Tromey <tromey at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sat, 5 May 2012 08:15:57 -0700
- Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase)
- References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFAC05.2070501@toojays.net> <m3bosdmi6p.fsf@fleche.redhat.com> <4FA49314.5020508@toojays.net>
> Wow, I knew it would take a while, but it seems the papers got stuck
> in limbo for several months.
:-(. That is just not right. If I had known, I'd have pinged the FSF.
> 2012-05-05 John Steele Scott <toojays@toojays.net>
>
> PR symtab/13277: Resolving opaque structures in ICC generated binaries.
> * gdb.dwarf2/dw2-icc-opaque.S: New file.
> * gdb.dwarf2/dw2-icc-opaque.exp: New file.
The only issue I spotted with this patch is the copyright year, which
needs to include 2012 as well, now. And while we are touching this,
why not add a '(C)' as well. I know we're very inconsistent with this,
but the the GNU Coding Standard shows it in all their example, and I
have a feeling that they would rather we did. So:
Copyright (C) 2011-2012 Free etc.
Not sure about the use of .asciz or not. We seem to have been using
.ascii exclusively so far. Jan might know better whether that's ok.
--
Joel